[LyX/master] Fix header.

[Scott Kostyshak]

On Mon, Mar 02, 2020 at 04:55:52PM +0100, Pavel Sanda wrote:
> On Mon, Mar 02, 2020 at 09:47:33AM -0500, Scott Kostyshak wrote:
> > On Sun, Mar 01, 2020 at 10:00:08PM +0100, Pavel Sanda wrote:
> > > On Sun, Mar 01, 2020 at 03:33:13PM -0500, Richard Kimberly Heck wrote:
> > > > But my understanding, anyway, is that the intent was to reduce the size of
> > > > includes where possible. André was really big on this for a while.
> > > 
> > > Yeah, overall compilation time was the reason.
> > 
> > Thanks for the explanations, Riki and Pavel. That makes sense. string.h
> > is 18k here as well. I had no idea it was that beefy.
> 
> Also my guess is that stl headers are heavily templated which would make it
> also slower to compile...
> 
> Very long time ago I made benchmarks in which full compile time would take
> ~9 mins and monolithic build avoiding recompiling includes for each cpp file
> would be ~5mins (all on a single core).

That is indeed a big difference.

> So in principle avoiding unnecessary includes is worth trying

I think we made progress this at some point at https://www.lyx.org/trac/ticket/6305

> though it's not
> straightforward to translate the results above into this situation. Simple
> experiment would be to include string header into each cpp file and see the
> difference in recompilation of the whole tree...

I'll pass on that exercise for now, but thanks for the explanations.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200302/f9e39b0a/attachment-0001.asc>