lyx2lyx error: \begin{english} is inside a bold layout instead of outside

[Scott Kostyshak]

On Fri, Feb 21, 2020 at 11:26:08AM -0500, Scott Kostyshak wrote:
> The following tests are failing on master:
> 
>   export/examples/ko/Welcome_lyx22 (Failed)
>   export/examples/ko/Welcome_lyx23 (Failed)
> 
> To reproduce manually, export Welcome.lyx in mater to LyX 2.3.x format.
> Then open the created file either with master or 2.3.x and compile with
> the default format (XeLaTeX) and get the following error:
> 
>   ! Extra }, or forgotten \endgroup.
> 
> This happens because the ERT "\begin{English}" is inside the bold
> layout. Either we need to end it at the end of the bold layout, or we
> need to move the "\begin{English}" before the bold starts. That is, the
> current LaTeX code being produced is:
> 
>   \textbf{\begin{english}Note for Linux users:}

Bisect gives the following:

  0d49918c0c815ead4ab70128fd6677118bf08c1e is the first bad commit
  commit 0d49918c0c815ead4ab70128fd6677118bf08c1e
  Author: Günter Milde <milde at lyx.org>
  Date:   Thu Jul 4 20:49:06 2019 +0200
  
      Refactor lyx2lyx for speed and simplicity.

Günter can you reproduce?

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200223/98b59309/attachment.asc>