[PATCH] Fix write to uninitialized bytes for XCB event

Pavel Sanda sanda at lyx.org
Wed Feb 19 18:22:36 UTC 2020


On Wed, Feb 19, 2020 at 06:28:51PM +0100, Enrico Forestieri wrote:
> Uh? In the Requirements section I read:
> 
>   First of all, you will need a C++11 standard conforming compiler, like gcc
>   (at least 4.7) or clang.

My undesrtanding was that only 4.8 is C++11 complete, especially wrt alignment support:
https://gcc.gnu.org/gcc-4.7/cxx0x_status.html

> I could not find the macro you mention in the current Qt sources (5.14.1),
> but I found the following in src/plugins/platforms/xcb/xcbconnection.h
> 
> template <typename T>
> struct alignas(32) q_padded_xcb_event : T { };
> 
> which is then used as
> 	q_padded_xcb_event<xcb_selection_notify_event_t> event = {};

Indeed, and now I know why:

https://github.com/qt/qtbase/commit/41705529d9995291324e1d06d45861ce63b1c72e#diff-5ee6702ad3813956cbebf9e7be8859d8

So we are at your solution anyway :)
Pavel


More information about the lyx-devel mailing list