Bug in Lyx 1.3.4 ?

[Stephan Witt]

Am 06.02.2020 um 20:54 schrieb Richard Kimberly Heck <rikiheck at lyx.org>:
> 
> On 2/6/20 2:46 PM, Enrico Forestieri wrote:
>> On Thu, Feb 06, 2020 at 01:53:34PM -0500, Richard Kimberly Heck wrote:
>>> On 2/6/20 9:58 AM, Enrico Forestieri wrote:
>>>> On Thu, Feb 06, 2020 at 01:52:15PM +0100, Pavel Sanda wrote:
>>>>> On Thu, Feb 06, 2020 at 08:15:45AM +0100, Stephan Witt wrote:
>>>>>> Am 06.02.2020 um 01:02 schrieb Richard Kimberly Heck <rikiheck at lyx.org>:
>>>>>>> I assume this is an old bug? Or is it a new one?
>>>>>> I can reproduce something similar with 2.4.0 too. But I cannot reproduce with 2.2.4.
>>>>> I can confirm it with Qt5 now.
>>>>> Bisect leads to:
>>>>> 
>>>>> commit a2d181905a95b3bb983dac60f3d9603413a01f34
>>>>> Author: Enrico Forestieri <forenr at lyx.org>
>>>>> Date:   Tue Jun 25 22:23:51 2019 +0200
>>>>> 
>>>>>    Fix bug #11586
>>>>> 
>>>>>    Do not replace a latex command with the corresponding symbol
>>>>>    in the unicodesymbols file unless it can be encoded in the
>>>>>    document encoding.
>>>> That commit simply exposes the bug, which is the fact that the buffer
>>>> member is not initialized. I think the patch by Stephan is correct.
>>> Does this warrant an emergency release?
>> I would say so. The program cannot crash simply because a toolbar is
>> used. I am surprised that it did not show up earlier, though.
> 
> My thinking, too.
> 
> If someone can commit the fix, I'll produce new tarballs this weekend
> and we can aim for an emergency release early next week.

I’ve commit and pushed the fix to master (59fa0b2592).

IMO there are other cases of this as well. But I think they are less
exposed to users and I cannot test then ATM because of a missing use case.

Stephan