Question on undo: Remove a finishUndo() after a recordUndo() ?

[Scott Kostyshak]

What would the consequences be of the attached patch?

From what I understand, finishUndo() is meant for when there have been
som undos of type INSERT or DELETE recorded, but PARAGRAPH_MOVE_DOWN
itself does not record any INSERTs or DELETEs. What would happen if
the finishUndo() is removed?

Is the cur.finishUndo() here meant for the case where a user is typing
and then executes pargraph-move-down and then continues typing? But
shouldn't a cur.recordUndo() end a sequence of INSERT type undos anyway?

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-a-finishUndo-after-a-recordUndo.patch
Type: text/x-diff
Size: 675 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200201/e49776dc/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200201/e49776dc/attachment.asc>