Source for 2.3.4

[Kornel Benko]

Am Tue, 14 Jan 2020 22:40:48 +0100
schrieb Yu Jin <technikmagma at gmail.com>:

> Compiling LyX 2.3.3 also works fine for me, but in
> https://www.lyx.org/trac/changeset/446769203f157ef5ff964e6d7355f840c8c91cac/lyxgit/development/cmake/lyx.rc
> the lyx.rc file was changed, lines 24 and 25 now contain "
> LYX_RELEASE_LEVEL,LYX_RELEASE_PATCH ", I could not find these anywhere else
> (unlike the other two,  LYX_MAJOR_VERSION,LYX_MINOR_VERSION, which are set
> in CMakeLists.txt (main folder)). So for me Visual Studio fails to compile
> with "unidentified keyword or key" error.
> 
> Eugene

Yes, commit 44676920.
Author:     Richard Kimberly Heck <rikiheck at lyx.org>
AuthorDate: Tue Jun 18 17:50:19 2019 -0400
Commit:     Richard Kimberly Heck <rikiheck at lyx.org>
CommitDate: Tue Jun 18 17:50:19 2019 -0400

    Use data from src/lyxwinres.rc to generate lyx.coff for the Windows
    build.
    
    Ideally, this would be done by cmake itself (as it is now done by
    autotools). But I do not know how to do that.

Riki, the values can be handled with configure_file() macro.
Instead of having for instance 'LYX_MAJOR_VERSION' we would use '@LYX_MAJOR_VERSION@'.

input:  lyx.rc.in (in src dir)
output: lyx.rc (in build-dir)
	configure_file(${LYX_CMAKE_DIR}/lyx.rc.in ${TOP_BINARY_DIR}/lyx.rc @ONLY)

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200114/955daa01/attachment.asc>