[patch] Refresh previews on branch toggle?

Richard Kimberly Heck rikiheck at lyx.org
Mon Dec 9 04:03:20 UTC 2019


On 12/8/19 9:20 PM, Scott Kostyshak wrote:
> Attached is a patch that refreshes previews whenever the user activates
> or deactivates a branch. The motivation for this patch is that if a
> child document is previewed in the master document, and if the child
> document has the branch inside it as well, the preview will be incorrect
> when the branch is toggled (without this patch).
>
> However, this patch will cause all previews to refresh. I'm concerned
> that the inefficiency is not worth the benefit. Any thoughts on this
> patch and any thoughts on an ideal solution? For example, would
> removePreviews() and updatePreviews() ideally have arguments that allow
> to specify which type of previews to update?

It makes sense to me.

Do we have to remove previews first?

Riki




More information about the lyx-devel mailing list