Buffers for Math Insets

[Richard Kimberly Heck]

On 10/12/19 5:25 AM, Jean-Marc Lasgouttes wrote:
> Le 12/10/2019 à 04:38, Richard Kimberly Heck a écrit :
>
>>> Might it make sense to call something like inset().setBuffer() whenever
>>> we go through updateBuffer? That is obviously overkill, but I don't
>>> know
>>> how else to ensure that the math insets are handled properly.
>>
>> PS We seem to reset the Buffers for whenever we move the mouse, so it
>> can't be that expensive. But if we do it whenever we updateBuffer, then
>> maybe we wouldn't need to do it whenever we move the mouse?
>
> What is the piece of code you are referring to? I agree that
> updateBuffer is a good place to do that and it would indeed not be
> expensive.

It's called from Cursor::push:

void Cursor::push(Inset & p)
{
    push_back(CursorSlice(p));
    p.setBuffer(*buffer());
}

So it's actually called whenever we descend into an inset as well.

Riki