Compilation Failure in Master

[Scott Kostyshak]

On Fri, May 16, 2025 at 10:13:22AM +0200, Kornel Benko wrote:
> Am Thu, 15 May 2025 17:50:26 +0200
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> > Do you mean CMake should turn set LYX_EXTERNAL_ICONV passed on the
> > version of the compiler?
> > 
> > I still don't know why it succeeds for me (with the default of
> > LYX_EXTERNAL_ICONV=OFF) and not for Riki. Could be different compiler
> > versions or could be different othe CMake flags. Kornel does it compile
> > successfully (although with warnings) for you?
> 
> The only warning I got is with gcc14 for mythes (but not iconv)
> CMake Warning:
> /usr2/src/lyx/lyx-test/3rdparty/mythes/1.2.5/mythes.cxx:247:25: warning: ‘char*
> __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int)’ output
> truncated before terminating nul copying as many bytes from a string as its length
> [-Wstringop-truncation] /usr2/src/lyx/lyx-test/3rdparty/mythes/1.2.5/mythes.cxx:249:25:
> warning: ‘char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long
> unsigned int)’ specified bound depends on the length of the source argument
> [-Wstringop-truncation]
> 
> No warnings with gcc13

The first warning I get (with Clang) is:

cd /home/scott/lyxbuilds/master-master/CMakeBuild/3rdparty/libiconv && /usr/lib/ccache/clang -DBUILDING_LIBCHARSET -DENABLE_RELOCATABLE=1 -DHAVE_CONFIG_H -DINSTALLDIR=\"\" -DINSTALLPREFIX=NU
LL -DIN_LIBRARY -DLIBDIR=\"\" -DNO_XMALLOC -Drelocate=libcharset_relocate -Dset_relocation_prefix=libcharset_set_relocation_prefix -I/home/scott/lyxbuilds/master-master/repo/3rdparty/libicon
v/1.15/srclib -I/home/scott/lyxbuilds/master-master/repo/3rdparty/libiconv/1.15/include -I/home/scott/lyxbuilds/master-master/CMakeBuild/libiconv/include -I/home/scott/lyxbuilds/master-maste
r/CMakeBuild/3rdparty/libiconv -I/home/scott/lyxbuilds/master-master/CMakeBuild -I/home/scott/lyxbuilds/master-master/repo/src -I/usr/include/enchant-2 -I/usr/include/hunspell -g   -Werror -
DBUILDING_LIBICONV -MD -MT 3rdparty/libiconv/CMakeFiles/iconv.dir/1.15/lib/iconv.c.o -MF CMakeFiles/iconv.dir/1.15/lib/iconv.c.o.d -o CMakeFiles/iconv.dir/1.15/lib/iconv.c.o -c /home/scott/l
yxbuilds/master-master/repo/3rdparty/libiconv/1.15/lib/iconv.c                                 
In file included from /home/scott/lyxbuilds/master-master/repo/3rdparty/libiconv/1.15/lib/iconv.c:71:                                                                                         
In file included from /home/scott/lyxbuilds/master-master/repo/3rdparty/libiconv/1.15/lib/converters.h:245:                                                                                   
In file included from /home/scott/lyxbuilds/master-master/repo/3rdparty/libiconv/1.15/lib/cp950.h:129:                                                                                        
/home/scott/lyxbuilds/master-master/repo/3rdparty/libiconv/1.15/lib/cp950ext.h:38:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]                 
   38 |   if ((c1 == 0xf9)) {                                                                                                                                                                 
      |        ~~~^~~~~~~                                                                                                                                                                     

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20250516/afd6d378/attachment.sig>