Compilation Failure in Master

[Richard Kimberly Heck]

On 5/14/25 4:41 PM, Scott Kostyshak wrote:
> On Wed, May 14, 2025 at 12:00:20PM -0400, Richard Kimberly Heck wrote:
>> In file included from
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loops.h:23,
>>                  from
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/iconv.c:136:
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:39:17:error:
>> conflicting types fo
>> r ‘mbrtowc’; have ‘size_t(void)’ {aka ‘long unsigned int(void)’}
>>    39 |   extern size_t mbrtowc();
>>       | ^~~~~~~
>> In file included from /cvs/lyx/lyx-devel/build/libiconv/include/iconv.h:110,
>>                  from
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/iconv.c:20:
>> /usr/include/wchar.h:321:15:note: previous declaration of ‘mbrtowc’ with
>> type ‘size_t(wchar_
>> t * restrict,  const char * restrict,  size_t,  mbstate_t * restrict)’ {aka
>> ‘long unsigned in
>> t(int * restrict,  const char * restrict,  long unsigned int,  mbstate_t *
>> restrict)’}
>>   321 | extern size_t mbrtowc(wchar_t *__restrict __pwc,
>>       | ^~~~~~~
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:In function
>> ‘wchar_from_loop_conv
>> ert’:
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:175:13:error: too
>> many arguments
>> to function ‘wcd->parent.fallbacks.wc_to_mb_fallback’; expected 0, have 4
>>   175 | wcd->parent.fallbacks.wc_to_mb_fallback(*fallback_inptr,
>>       | ^~~~~~~~~~~~~~~~~~
>> /cvs/lyx/lyx-devel/build/libiconv/include/iconv.h:200:33:note: declared here
>>   200 |   iconv_wchar_wc_to_mb_fallback wc_to_mb_fallback;
>>       | ^~~~~~~~~~~~~~~~~
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:In function
>> ‘wchar_to_loop_conver
>> t’:
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:356:15:error: too
>> many arguments
>> to function ‘mbrtowc’; expected 0, have 4
>>   356 |         res = mbrtowc(&wc,buf,bufcount,&state);
>>       | ^~~~~~~~~~
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:39:17:note:
>> declared here
>>    39 |   extern size_t mbrtowc();
>>       | ^~~~~~~
>> /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wchar.h:372:15:error: too
>> many arguments
>> to function ‘wcd->parent.fallbacks.mb_to_wc_fallback’; expected 0, have 5
>>   372 | wcd->parent.fallbacks.mb_to_wc_fallback(*inbuf, incount,
>>       | ^~~~~~~~~
>> /cvs/lyx/lyx-devel/build/libiconv/include/iconv.h:199:33:note: declared here
>>   199 |   iconv_wchar_mb_to_wc_fallback mb_to_wc_fallback;
>>       | ^~~~~~~~~~~~~~~~~
>> make[2]: *** [3rdparty/libiconv/CMakeFiles/iconv.dir/build.make:82:
>> 3rdparty/libiconv/CMakeFi
>> les/iconv.dir/1.15/lib/iconv.c.o] Error 1
>> make[2]: Leaving directory '/cvs/lyx/lyx-devel/build'
>> make[1]: *** [CMakeFiles/Makefile2:987:
>> 3rdparty/libiconv/CMakeFiles/iconv.dir/all] Error 2
>> make[1]: Leaving directory '/cvs/lyx/lyx-devel/build'
>> make: *** [Makefile:149: all] Error 2
>  From what I understand you're compiling with CMake and with
> LYX_EXTERNAL_ICONV set to OFF. If I do that, it compiles successfully
> for me (although I have to turn off -Werror because there are warnings).

I was just using defaults:

mkdir build
cd build
cmake ..

and that's it. If I set LYX_EXTERNAL_ICONV to ON, then it builds. The 
error seems to be in building iconv itself.

This is on Fedora 41, with gcc 15.1.1.

Riki