very, very small problem with location of buttons in find and replace

[Kornel Benko]

Am Wed, 19 Mar 2025 11:24:35 +0100
schrieb Jean-Marc Lasgouttes <lasgouttes at lyx.org>:

> Le 19/03/2025 à 11:18, Pavel Sanda a écrit :
> > On Tue, Mar 18, 2025 at 03:19:21PM +0100, Jean-Marc Lasgouttes wrote:  
> >> Le 18/03/2025 ?? 15:16, Pavel Sanda a écrit :  
> >>> I am not sure I described the problem comprehensibly. The bug is very likely
> >>> due to some broken logic in search function and I have hard time to see
> >>> how scrolling code should affect this.  
> >>
> >> I see the bug you describe (I managed to get a crash too, but it may be
> >> related to my experiments). I also do not see how it can be related to this
> >> commit, but I am searching. For now, I am blocked by not knowing the
> >> architecture of findadv.  
> > 
> > I did my own bisect and it came down to this commit:
> > 
> > e5c31699b4d8fd13c71212158d835c7fa750100f is the first bad commit
> > commit e5c31699b4d8fd13c71212158d835c7fa750100f
> > Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
> > Date:   Fri Sep 6 16:21:47 2024 +0200
> > 
> >      Remove handling of dispatched() property in BufferView::dispatch
> >      
> >      As indicated in DispatchResult.h, this is only needed in insets'
> >      doDispatch() methods, where lfuns can be delegated to a higher lever.  
> 
> Thanks. This makes much more sense. I did not remember this patch, so I 
> will have to review it to see if some parts still make sense.
> 
> JMarc

Would be nice to resolve this. Bisecting can be confusing.
On the first bisect I tried HEAD <-> HEAD~600 but stopped at 3 steps before end.
On the second bisect it was HEAD~590 <-> HEAD~1200. I supposed I had cowered all,
but apparently not. Thanks Pavel to repeat the procedure.

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20250319/cc6ed39d/attachment-0001.sig>