Opening Document > Settings feels a bit laggy to me

[Jean-Marc Lasgouttes]

Le 12/03/2025 à 11:35, Scott Kostyshak a écrit :
> On Mon, Mar 10, 2025 at 09:53:34AM +0100, Jürgen Spitzmüller wrote:
>> Am Sonntag, dem 09.03.2025 um 18:23 +0100 schrieb Jean-Marc Lasgouttes:
>>> With 2.5, this is dwarfed by ColorCombo, but that is a different
>>> story.
>>
>> One thing that probably is expensive (and might be optimized) is that
>> the color combo needs to be updated regularly to catch up with the
>> custom colors (from buffer params).
>>
>> We might employ signals and slots here and maybe also only update these
>> handful of entries rather than the whole list of colors.
>>
>> Alas, I am a bit short of time now (classes started).
> 
> This seems to be triggered by a few different code paths (I'm guessing
> anything that calls GuiDocument::updateCustomColors()?). For example
> table settings, adding a module. Is that expected?
> 
> Is it the for loop in updateCustomColors() that we think is taking up
> the cycles?

Isn't it possible to have a single model for these colors and use it in 
several combo boxes? I see 21 calls to updateCustomColors just to open 
the document settings on an empty document.

JMarc