[LyX/master] Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor()

[Pavel Sanda]

On Thu, Sep 19, 2024 at 10:56:51PM +0200, Jean-Marc Lasgouttes wrote:
> Le 10/09/2024 ?? 15:56, Pavel Sanda a écrit :
> > On Fri, Sep 06, 2024 at 03:33:24PM +0200, Jean-Marc Lasgouttes wrote:
> > > Then, I changed the outline to yield the same effect. I expect some of you
> > > to hate it, but discussion is good and this is not the final design. Again,
> > > clicking several times on an element shows what is below it, around it, and
> > > so forth.
> > 
> > If you are interested in feedback, I launched master to test outline and found
> > that centering is somewhat annoying as I expect to see way more content following
> > the (sub/..)section title I clicked on than above it. So I would prefer to stay
> > to 2.3 situation.
> 
> Before I revert that part, did you try to click several times on the toc
> entry? I personally think that it is a good way to look around cursor
> position.

Yes, I tried. I am not against that functionality, but I would like the
first click puts the cursor on the top.

> > > * there is some ad-hoc code that adds twice the height of a typical row
> > > before the paragraph. In passing, this means that a tall row (Chapter) will
> > > be barely shown completely. I remember that changing that has met resistance
> > > and I had to revert it. How is this useful to you?
> > 
> > Maybe it's related to the discussion how search scrolling is done? One pushback
> > I remember was that we lost few lines of context on top before the searched
> > text at some point and made you scroll the context back to screen...
> 
> So, what do you want t see above? The previous row of text? Two rows? Just
> ask, I can give it a go to see whether it works.

Two columns seem reasonable, but no hard opinion.

Pavel