ctests failing on current master

Scott Kostyshak skostysh at lyx.org
Wed Sep 18 09:42:34 UTC 2024


On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote:
> Am Tue, 17 Sep 2024 21:53:07 +0200
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> > > Should be working now.  
> > 
> > Very nice! Thanks!
> > 
> > What do you think of the attached patch? If you agree with the approach,
> > can you please double-check the code carefully?  Specifically, I don't
> > know if my use of _err vs. _errx is correct. Feel free to adapt and
> > commit.
> 
> The idea was (I think) not to error out if export to pdflatex went wrong. For instance if
> we are using docbook only.

Ah that makes sense and now I understand the previous code better.

> But now using pdf your patch makes more sense.

Sounds good. I'll apply it. First I will see if any new tests fail with
it though.

> P.S.
> Thanks for the amend BTW.

I only realized it because of Bash highlighting.

> It probably happened while using emacs _and_ vi simultaneously
> on the same file :(

That does sounds like playing with some strong chemicals that don't mix ;)

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20240918/2b704851/attachment.asc>


More information about the lyx-devel mailing list