Coverity musings

[Pavel Sanda]

On Fri, Sep 13, 2024 at 05:54:05PM +0200, Jean-Marc Lasgouttes wrote:
> * still lots of places where Coverity wants us to use std::move because the
> variable that is copied will not be used any more. I tend to think that we
> should avoid that and reduce our use of move() to the minimum, unless
> profiling shows that we have an issue. Do we have an agreement on that?

No surprise, I agree.

> * Places where I understand the issue, but fixing requires some work and is
> a bit scary. Example in the patch below: Jürgen, could you please have a
> look and tell me why we should not do that? It is too simple, I fear I am
> missing something.

Can you explain what that construct works?
If I understand correctly we are changing the underlying structure
and that does not feel right for "search" procedure.
Apart from that if we search extensively the memory will grow as well?

Pavel