Coverity musings

[Richard Kimberly Heck]

On 9/13/24 11:54 AM, Jean-Marc Lasgouttes wrote:
> So what remains now?
>
> * still lots of places where Coverity wants us to use std::move 
> because the variable that is copied will not be used any more. I tend 
> to think that we should avoid that and reduce our use of move() to the 
> minimum, unless profiling shows that we have an issue. Do we have an 
> agreement on that?

Yes here.

> * Places where I understand the issue, but fixing requires some work 
> and is a bit scary. Example in the patch below: Jürgen, could you 
> please have a look and tell me why we should not do that? It is too 
> simple, I fear I am missing something.

I suspect that the reason people did not do it that way is the one you 
mention: because it creates a new key value. I guess these are always 
initialized properly?

> * Places where I understand the program, but am not sure of a proper fix.
>
> * Places where I do not even understand what the issue is :(

Happy to have a look at some of those.

Riki