[LyX/master] Do not handle special case where buffer == NULL

Jean-Marc Lasgouttes lasgouttes at lyx.org
Thu Sep 12 06:42:59 UTC 2024



Le 9 septembre 2024 19:01:09 GMT+02:00, "José Matos" <jaomatos at gmail.com> a écrit :
>On Mon, 2024-09-09 at 17:54 +0200, Jean-Marc Lasgouttes wrote:
>> string const arg = (type.empty()) ? move(label) : move(label) + " " 
>> + type;
>
>I can understand the first move. That makes all the sense to me.
>
>I can not understand why you use move and then add it to a chr * (that
>will be converted to a string) plus a string. Why not then move(type)?

I totally agree with you, this is useless. We should disregard those coverity warnings for strings IMO.

>PS: Lately I have been more interested in understand annotations in
>python that apply/are related to type hinting but not only that. I knew
>this before but now I understand it (going up in the Bloom's taxonomy).

And ? Does it change your approach to life ? We want to know !

JMarc 


More information about the lyx-devel mailing list