[LyX/master] use std::move() instead of copying when value is no longer used

Jean-Marc Lasgouttes lasgouttes at lyx.org
Wed Sep 11 17:56:00 UTC 2024


Le 07/09/2024 à 13:42, Jürgen Spitzmüller a écrit :
> Am Samstag, dem 07.09.2024 um 13:22 +0200 schrieb Jean-Marc Lasgouttes:
>> I have been resisting to making these changes because someone may
>> change the code and use the variable afterwards. But I may be wrong
>> after all.
> 
> I am not sure at all. I did some research how useful this sort of
> advise is, and people seem to be ambivalent about it. So I am perfectly
> fine with reverting it and ignoring the message (or let coverity ignore
> it).

I have slowly begun to look at this. This lead to a few fixes that you 
saw, and much more Ignoring of issues at coverity level.

Fox now I only ignored the issues related to strings. There are other 
(with cursors, etc.) where we have to check whether the cost is 
important. I think these will get ignored too.

JMarc


More information about the lyx-devel mailing list