GCC >= 5? (was: [patch] Removal of strfwd.h)

[Pavel Sanda]

On Fri, Oct 04, 2024 at 04:46:01PM +0200, Jean-Marc Lasgouttes wrote:
> I did not read completely your comment in docstring.h. I think we can get
> rid completely of the names trvstring and trivdocstring soon after this
> landed. 

If we are sure that the thread safety issue is gone for all reasonable
STL implemtations then yes (so far I saw only explicit ack for gcc5,
but did not googled around).

I saw trivstring declarations across the code as useful marker of thread
sensitivity if we discover that the above is not true and need to fix it again.

> In this view, I do not think that we need a test to check that the
> c++ implementation of string works, do we?

I meant is as a check for our docstring wrapper. But I don't have
any skin in this game and am completely fine with removing it.

Pavel