GCC >= 5? (was: [patch] Removal of strfwd.h)

[Pavel Sanda]

On Fri, Oct 04, 2024 at 12:51:56PM +0200, Enrico Forestieri wrote:
> On Fri, Oct 04, 2024 at 11:52:01AM +0200, Pavel Sanda wrote:
> > 
> > I am all for ditching trivstring, but it all depends on Enrico's stance,
> > I didn't
> > folow the previous discussion on strings and COW, so I have little idea
> > what is the right course of action.
> 
> Cygwin does not need trivstring. It was using the implementation in
> src/support/trivstring.cpp simply because we wrongly decide that std::string
> implementation uses cow when _GLIBCXX_USE_CXX11_ABI is set.
> 
> I think that if we ditch trivstring we don't need to set
> STD_STRING_USES_COW. In this case, the patch I proposed to check whether cow
> is actually used or not will also not be necessary.

So are you able to compile on cygwin after these two patches applied on top
of each other (first strfwd out, then trivstring out)?

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_strfwd.patch
Type: text/x-diff
Size: 36550 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20241004/9bf3fe8f/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_trivstring.patch
Type: text/x-diff
Size: 14835 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20241004/9bf3fe8f/attachment-0003.patch>