GCC >= 5? (was: [patch] Removal of strfwd.h)

Enrico Forestieri forenr at lyx.org
Fri Oct 4 10:51:56 UTC 2024


On Fri, Oct 04, 2024 at 11:52:01AM +0200, Pavel Sanda wrote:
> 
>I am all for ditching trivstring, but it all depends on Enrico's 
>stance, I didn't
>folow the previous discussion on strings and COW, so I have little idea
>what is the right course of action.

Cygwin does not need trivstring. It was using the implementation in 
src/support/trivstring.cpp simply because we wrongly decide that 
std::string implementation uses cow when _GLIBCXX_USE_CXX11_ABI is set.

I think that if we ditch trivstring we don't need to set 
STD_STRING_USES_COW. In this case, the patch I proposed to check whether 
cow is actually used or not will also not be necessary.

-- 
Enrico


More information about the lyx-devel mailing list