[patch] Removal of strfwd.h (was: When to use strfwd.h)

[Enrico Forestieri]

On Thu, Oct 03, 2024 at 10:04:04PM +0200, Enrico Forestieri wrote:
> 
>On Thu, Oct 03, 2024 at 03:57:56PM +0200, Pavel Sanda wrote:
>>On Thu, Oct 03, 2024 at 01:35:55AM +0200, Enrico Forestieri wrote:
>>>And, after adding "#include <string>" to src/support/trivstring.h as
>>>suggested, it fails in this new way:
>>
>>Adding "#include <ostream>" makes cygwin happy?
>
>It helps. Compilation proceeds until the following failure:

However, applying the attached patch it compiles and works fine.
See https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg219747.html 
for the reason the patch is right.

-- 
Enrico
-------------- next part --------------
diff --git a/config/lyxinclude.m4 b/config/lyxinclude.m4
index 03e40581c9..47b84fc529 100644
--- a/config/lyxinclude.m4
+++ b/config/lyxinclude.m4
@@ -283,7 +283,8 @@ if test $lyx_cv_lib_stdcxx = "yes" ; then
   if test $lyx_cv_lib_stdcxx_cxx11_abi = "yes" ; then
     AC_DEFINE(USE_GLIBCXX_CXX11_ABI, 1, [use GNU libstdc++ with C++11 ABI])
   else
-    AC_DEFINE(STD_STRING_USES_COW, 1, [std::string uses copy-on-write])
+    AS_CASE([$host], [*cygwin*], [],
+    [AC_DEFINE(STD_STRING_USES_COW, 1, [std::string uses copy-on-write])])
   fi
 else
   if test $lyx_cv_prog_clang = "yes" ; then