[patch] Removal of strfwd.h (was: When to use strfwd.h)

[Enrico Forestieri]

On Thu, Oct 03, 2024 at 03:57:56PM +0200, Pavel Sanda wrote:
>On Thu, Oct 03, 2024 at 01:35:55AM +0200, Enrico Forestieri wrote:
>> And, after adding "#include <string>" to src/support/trivstring.h as
>> suggested, it fails in this new way:
>
>Adding "#include <ostream>" makes cygwin happy?

It helps. Compilation proceeds until the following failure:

make[6]: Entering directory '/usr/local/src/lyx/lyx-devel/build-cygwin/src/frontends/qt'
   CXX      GuiImage.o
In file included from ../../../../src/frontends/qt/GuiImage.cpp:18:
../../../../src/Format.h:108:20: error: field ‘name_’ has incomplete type ‘lyx::trivstring’ {aka ‘lyx::trivial_string<char>’}
   108 |         trivstring name_;
       |                    ^~~~~
In file included from ../../../../src/Buffer.h:19,
                  from ../../../../src/frontends/qt/qt_helpers.h:16,
                  from ../../../../src/frontends/qt/GuiImage.cpp:16:
../../../../src/support/docstring.h:69:31: note: declaration of ‘lyx::trivstring’ {aka ‘class lyx::trivial_string<char>’}
    69 | template<typename Char> class trivial_string;
       |                               ^~~~~~~~~~~~~~
../../../../src/Format.h:112:23: error: field ‘prettyname_’ has incomplete type ‘lyx::trivdocstring’ {aka ‘lyx::trivial_string<unsigned int>’}
   112 |         trivdocstring prettyname_;
       |                       ^~~~~~~~~~~
../../../../src/support/docstring.h:69:31: note: declaration of ‘lyx::trivdocstring’ {aka ‘class lyx::trivial_string<unsigned int>’}
    69 | template<typename Char> class trivial_string;
       |                               ^~~~~~~~~~~~~~
../../../../src/Format.h:114:20: error: field ‘shortcut_’ has incomplete type ‘lyx::trivstring’ {aka ‘lyx::trivial_string<char>’}
   114 |         trivstring shortcut_;
       |                    ^~~~~~~~~
../../../../src/support/docstring.h:69:31: note: declaration of ‘lyx::trivstring’ {aka ‘class lyx::trivial_string<char>’}
    69 | template<typename Char> class trivial_string;
       |                               ^~~~~~~~~~~~~~
../../../../src/Format.h:122:20: error: field ‘viewer_’ has incomplete type ‘lyx::trivstring’ {aka ‘lyx::trivial_string<char>’}
   122 |         trivstring viewer_;
       |                    ^~~~~~~
../../../../src/support/docstring.h:69:31: note: declaration of ‘lyx::trivstring’ {aka ‘class lyx::trivial_string<char>’}
    69 | template<typename Char> class trivial_string;
       |                               ^~~~~~~~~~~~~~
../../../../src/Format.h:124:20: error: field ‘editor_’ has incomplete type ‘lyx::trivstring’ {aka ‘lyx::trivial_string<char>’}
   124 |         trivstring editor_;
       |                    ^~~~~~~
../../../../src/support/docstring.h:69:31: note: declaration of ‘lyx::trivstring’ {aka ‘class lyx::trivial_string<char>’}
    69 | template<typename Char> class trivial_string;
       |                               ^~~~~~~~~~~~~~
../../../../src/Format.h:132:20: error: field ‘mime_’ has incomplete type ‘lyx::trivstring’ {aka ‘lyx::trivial_string<char>’}
   132 |         trivstring mime_;
       |                    ^~~~~
../../../../src/support/docstring.h:69:31: note: declaration of ‘lyx::trivstring’ {aka ‘class lyx::trivial_string<char>’}
    69 | template<typename Char> class trivial_string;
       |                               ^~~~~~~~~~~~~~
make[6]: *** [Makefile:934: GuiImage.o] Error 1
make[6]: Leaving directory '/usr/local/src/lyx/lyx-devel/build-cygwin/src/frontends/qt'
make[5]: *** [Makefile:776: all] Error 2
make[5]: Leaving directory '/usr/local/src/lyx/lyx-devel/build-cygwin/src/frontends/qt'
make[4]: *** [Makefile:774: all-recursive] Error 1
make[4]: Leaving directory '/usr/local/src/lyx/lyx-devel/build-cygwin/src/frontends'
make[3]: *** [Makefile:2397: all-recursive] Error 1
make[3]: Leaving directory '/usr/local/src/lyx/lyx-devel/build-cygwin/src'
make[2]: *** [Makefile:1495: all] Error 2
make[2]: Leaving directory '/usr/local/src/lyx/lyx-devel/build-cygwin/src'
make[1]: *** [Makefile:568: all-recursive] Error 1
make[1]: Leaving directory '/usr/local/src/lyx/lyx-devel/build-cygwin'
make: *** [Makefile:462: all] Error 2

-- 
Enrico