[patch] Removal of strfwd.h (was: When to use strfwd.h)

[Pavel Sanda]

On Tue, Oct 01, 2024 at 07:09:03PM +0200, Jean-Marc Lasgouttes wrote:
> Le 01/10/2024 ?? 18:18, Pavel Sanda a écrit :
> > I could produce patch which ditches strfwd and let Enrico/Eugene test it?
> > 
> >  From what I see it might do more harm than good in linux nowadys...
> 
> Go for it. And do not forget to remove <string> and/or <ostream> from the
> cpp file.

This is my take on this. I moved docstring definitions to docstring.h where
it actually belongs and made <string> inclusion mandatory.

I am little bit scared of commits like a0a472c16e09 so I tried to avoid any
additional "improvements" within docstring.h itself and am still concerned
about the effects of this patch on MSVC. This patch does not remove the header
file itself (yet).
Anyway without trying we'll never get rid of this archaic stuff.

Any additional comments?

Enrico/Eugene/Stephan can you confirm you can compile and run master
with the attached patch?

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strfwd.patch
Type: text/x-diff
Size: 35769 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20241001/52664c20/attachment-0001.patch>