Missing includes

[Lorenzo Bertini]

Sorry, it was Clipboard.h instead of GuiClipboard.h. Moreover, I found that
ConsoleApplicationPrivate.h does a forward declaration of
ConsoleApplication, but uses one of the methods. This required the full
declaration of the class, we may need to include ConsoleApplication.h in
there.

Also, moc_GuiViewSource.cpp gives an error of "incomplete type" if we don't
include TexRow.h in GuiViewSource.h, and the same thing with GuiDocument.h
and TempFile.h.

I have included everything in the patch. When I look at those errors, the
fix seems like a best practice to me, this is why I'm proposing the
changes. Also, I can't figure how can CMake and Autotools still finish the
build.

My build environment Fedora 41 with qt6 and a Meson build script I've been
working on. So far it's looking good and with the changes in the patch it
compiles everything and it gets to the final linking stage. Then it fails
on "multiple definitions of function" over the cpp files and the moc
generated ones. I still need to figure this one out.

Cheers,
Lorenzo

Il giorno dom 17 nov 2024 alle ore 20:43 Pavel Sanda <sanda at lyx.org> ha
scritto:

> On Sun, Nov 17, 2024 at 12:12:11PM +0100, Lorenzo Bertini wrote:
> > Dear devs,
> > when trying to port LyX to yet another build system I found that
> > src/frontends/GuiClipboard.h is missing <string> and
> "support/docstring.h",
> > and GuiSearch.h only "support/docstring.h". I don't exactly know how
> > autotools manages to build anyway, but the files use std::string and
> > docstring without including, so maybe they should include.
>
> My doing, indeed I was expecting this might break on some different
> setup. What exactly is your "build environment"?
>
> Is this patch enough?
>
> Pavel
> --
> lyx-devel mailing list
> lyx-devel at lists.lyx.org
> https://lists.lyx.org/mailman/listinfo/lyx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20241118/ca466410/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-meson-build.patch
Type: text/x-patch
Size: 2186 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20241118/ca466410/attachment.bin>