[wip][patch] use qmake with autoconf for qt5 too

Enrico Forestieri forenr at lyx.org
Sat Jun 15 14:38:18 UTC 2024


On Sat, Jun 15, 2024 at 01:23:52PM +0200, Enrico Forestieri wrote:
>On Fri, Jun 14, 2024 at 08:09:00PM +0200, Jean-Marc Lasgouttes wrote:
>>
>>Could you people have a go at it before I push it?
>
>I tried it with native Windows and Cygwin with GDI backend instead of X11.
>
>In both cases it detected the winextras module and added appropriate 
>includes and libraries. However, while in the native case I could 
>paste graphics in EMF format, I was not able to do it in the Cygwin 
>case.
>
>After investigating, it turned out that the previous method was taking 
>into account the DEFINES and PRL_EXPORT_DEFINES variables present in 
>the platform's qmake.conf file, in the mkspecs directory, while the 
>qmake method does not.
>
>After moving those definitions into CPPFLAGS and passing them to 
>configure, the Cygwin build also worked fine.
>
>I wonder if this change might somehow compromise other configurations 
>as well. You know, if it works... ;)

Digging further it turns out that only PRL_EXPORT_DEFINES was taken into 
account for producing pkgconfig files. The definitions in DEFINES are 
only meant for building Qt and it is not appropriate exporting them.

So, all in all, it seems that only who relies on PRL_EXPORT_DEFINES 
would be affected. Given that I am not sure I am not the only one 
(actually, I am pretty sure I am the only one, as grep in mkspecs 
returns nothing ;), the change does not seem to be harmful...

-- 
Enrico


More information about the lyx-devel mailing list