[LyX/master] Fix change tracking colors with RTL languages (#12923)

[Pavel Sanda]

On Mon, Jun 10, 2024 at 12:19:18PM +0000, Udi Fogiel wrote:
> commit a5749b9c1f5c5b42e6d6db7cd9f2aab16bc28f5b
> Author: Udi Fogiel <ufogiel at lyx.org>
> Date:   Mon Jun 10 15:19:08 2024 +0300
> 
>     Fix change tracking colors with RTL languages (#12923)
> ---
>  src/LaTeXFeatures.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/LaTeXFeatures.cpp b/src/LaTeXFeatures.cpp
> index 4a4385fc01..e68f850d0a 100644
> --- a/src/LaTeXFeatures.cpp
> +++ b/src/LaTeXFeatures.cpp
> @@ -208,8 +208,8 @@ static docstring const lyxdot_def = from_ascii(
>  
>  static docstring const changetracking_xcolor_ulem_base_def = from_ascii(
>  	"%% Change tracking with ulem and xcolor: base macros\n"
> -	"\\DeclareRobustCommand{\\mklyxadded}[1]{\\bgroup\\color{lyxadded}{}#1\\egroup}\n"
> -	"\\DeclareRobustCommand{\\mklyxdeleted}[1]{\\bgroup\\color{lyxdeleted}\\mklyxsout{#1}\\egroup}\n"
> +	"\\DeclareRobustCommand{\\mklyxadded}[1]{\\textcolor{lyxadded}\\bgroup#1\\egroup}\n"
> +	"\\DeclareRobustCommand{\\mklyxdeleted}[1]{\\textcolor{lyxdeleted}\\bgroup\\mklyxsout{#1}\\egroup}\n"
>  	"\\DeclareRobustCommand{\\mklyxsout}[1]{\\ifx\\\\#1\\else\\sout{#1}\\fi}\n");
>  
>  static docstring const changetracking_xcolor_ulem_def = from_ascii(

I am sorry if I missed some discussion on ML (please redirect me then),
but is this patch just RTL related or it can break something in CT
in "normal" documents?

Pavel