[PATCH] WIP: rewrite statistics code

[Scott Kostyshak]

On Wed, Jul 24, 2024 at 06:10:42PM GMT, Jean-Marc Lasgouttes wrote:
> Le 24/07/2024 à 09:43, Jean-Marc Lasgouttes a écrit :
> > > All in all this patch is nice piece of work! :)
> > 
> > Thanks. It needs some cleanup, so I will push it later.
> 
> I found the time, the code is now in.

When compiling I now get the following:

[ 29%] Building CXX object src/frontends/qt/CMakeFiles/frontend_qt.dir/DialogFactory.cpp.o
cd /home/scott/lyxbuilds/master-master/CMakeBuild/src/frontends/qt && /usr/lib/ccache/clang++ -DBOOST_USER_CONFIG="<config.h>" -DLYX_BUILD_QT_FRONTEND -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GENUINE_STR -DQT_GUI_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -I/home/scott/lyxbuilds/master-master/CMakeBuild -I/home/scott/lyxbuilds/master-master/repo/src -I/usr/include/enchant-2 -I/usr/include/hunspell -I/home/scott/lyxbuilds/master-master/repo/3rdparty/boost -I/home/scott/lyxbuilds/master-master/repo/3rdparty/nod -I/home/scott/lyxbuilds/master-master/repo/src/frontends -I/home/scott/lyxbuilds/master-master/repo/src/frontends/qt -I/home/scott/lyxbuilds/master-master/CMakeBuild/src/frontends/qt -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtConcurrent -isystem /usr/include/x86_64-linux-gnu/qt5/QtSvg -Wall -Wextra -Wno-deprecated-copy --std=c++20 -Wno-deprecated-register -DENABLE_ASSERTIONS=1 -fno-strict-aliasing  -O0 -g3 -D_DEBUG   -Werror -fPIC -std=c++20 -MD -MT src/frontends/qt/CMakeFiles/frontend_qt.dir/DialogFactory.cpp.o -MF CMakeFiles/frontend_qt.dir/DialogFactory.cpp.o.d -o CMakeFiles/frontend_qt.dir/DialogFactory.cpp.o -c /home/scott/lyxbuilds/master-master/repo/src/frontends/qt/DialogFactory.cpp
In file included from /home/scott/lyxbuilds/master-master/repo/src/frontends/qt/DialogFactory.cpp:58:
In file included from /home/scott/lyxbuilds/master-master/repo/src/frontends/qt/GuiTabular.h:20:
/home/scott/lyxbuilds/master-master/repo/src/insets/InsetTabular.h:1120:7: error: 'updateStatistics' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        void updateStatistics(Statistics & stats) const;
             ^
/home/scott/lyxbuilds/master-master/repo/src/insets/Inset.h:485:15: note: overridden virtual function is here
        virtual void updateStatistics(Statistics & stats) const;
                     ^

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20240724/152c0b9c/attachment.asc>