[PATCH] WIP: rewrite statistics code

[Jean-Marc Lasgouttes]

Le 24 juillet 2024 01:57:01 GMT+02:00, Pavel Sanda <sanda at lyx.org> a écrit :
>I tested and do not see any counting difference in my selected document and
>confirm that profiling gives about 3x better time with your patch.

Thanks for testing. To be frank, I have been disappointed at first to have "only" a 3x speedup :) I am not sure how to improve on that, but that's probably ok.

The take away is: don't use forwardPar to iterate a document (yes updateMacros, I'm looking at you!).

>On top of that this speed up was good enough that I do not see visually
>noticeable hiccups while moving with the cursor in User Guide anymore - but
>that's also due to the fact that cursor moving is still somewhat slow on fast
>repeat rates compared to other editors or terminals I have, heh ;). 

Good, that was the point. The code I proposed to avoid running updateMacros on an unchanged document can be used here too.

>All in all this patch is nice piece of work! :)

Thanks. It needs some cleanup, so I will push it later.

>Is the original problem reported on users list solved by this rewrite
>or the lags created by citations are currently solved only by disabling
>the stat feature anyway?

Jürgen took care of this one 

JMarc