windows preview bug fix

Enrico Forestieri forenr at lyx.org
Sat Feb 17 09:41:45 UTC 2024


On Fri, Feb 16, 2024 at 03:28:25PM +0000, José Matos wrote:
> 
>On Fri, 2024-02-16 at 15:23 +0200, Idan Pazi wrote:
>>
>> Apparently, the returned value from win32file.ReadFile should be
>> converted to a string. 
>
>> Fix patch attached.
>> Thank you, Idan
>
>What is the encoding of the bytes? Is it UTF8?
>If so the patch look right.
>
>@Enrico, what do you think?

I don't have a native Windows python 3 installation and the python 
distributed with LyX on Windows doesn't include PyWin extension modules. 
Thus I cannot test that code. However, I don't think that 
win32file.ReadFile() returns utf8. Most probably it returns some 8-bit 
encoding corresponding to the current code page. But, even using 
win32file.ReadFileW() (assuming it exists) that would return utf16.

-- 
Enrico


More information about the lyx-devel mailing list