[for enrico] Question: do we still need that?

Jean-Marc Lasgouttes lasgouttes at lyx.org
Thu Aug 29 17:20:05 UTC 2024


Le 29/08/2024 à 13:51, Enrico Forestieri a écrit :
>> What I did not do is remove the hand-made parsing of geometry that is 
>> used for window-new lfun only on Windows (why?). Can this go away?
> 
> That code was necessary for Qt4, where -qwindowgeometry was not 
> available. It was necessary on Windows because the backend did not 
> support -geometry and we had to parse it by ourselves. When an option is 
> supported by the backend, it is automatically removed. This is now the 
> case with -qwindowgeometry, so that this code can now go away.

I agree with that. My concern is that it changes a documented argument 
to LFUN_WINDOW_NEW, although not really useful (limited to Windows). I 
will just document it in release notes then.

Actually, it seems to me that -geometry did not work anymore in 
unix/x11. The old logic in parse_geometry() seems backwards to me.

JMarc




More information about the lyx-devel mailing list