[for enrico] Question: do we still need that?
Jean-Marc Lasgouttes
lasgouttes at lyx.org
Wed Aug 28 13:54:28 UTC 2024
In createAppplication, we have:
#if !defined(QPA_XCB)
// prune -geometry argument(s) by shifting
// the following ones 2 places down.
for (int i = 0 ; i < argc ; ++i) {
if (strcmp(argv[i], "-geometry") == 0) {
int const remove = (i+1) < argc ? 2 : 1;
argc -= remove;
for (int j = i; j < argc; ++j)
argv[j] = argv[j + remove];
--i;
}
}
#endif
Archaeology tells me that it came from win32 code, where the goal was
likely to accept and ignore -geometry parameter on non-x11 binaries.
Can I get rid of it? The current platform is known only after creating
the QGuiApplication object, and this requires (argv,argc) as argument.
Removing silently these arguments seems a bit silly to me anyway.
Is anyone relying on this?
JMarc
More information about the lyx-devel
mailing list