2.3.x does not compile on Windows

[Kornel Benko]

Am Fri, 12 Apr 2024 21:50:28 +0200
schrieb Yu Jin <technikmagma at gmail.com>:

> Am Fr., 12. Apr. 2024 um 09:56 Uhr schrieb Kornel Benko <kornel at lyx.org>:
> 
> > Am Thu, 11 Apr 2024 17:13:20 +0200
> > schrieb Yu Jin:
> >
> > > Am Do., 11. Apr. 2024 um 10:17 Uhr schrieb Kornel Benko:
> > >
> > > > Am Wed, 10 Apr 2024 21:02:40 +0200
> > > > schrieb Yu Jin:
> > > >
> >
> > [snip]
> >
> > > > Please check ./development/cmake/modules/LyXMacros.cmake:471
> > > >
> > >
> > > On the 2.3.x branch there LyXMacros.cmake file only contains  403 lines.
> > >
> >
> >
> > I completely forgot the 2.3 branch.
> >
> > Please check development/cmake/modules/FindCXX11Compiler.cmake:47
> > and set CXX11_FLAG_CANDIDATES appropriate.
> > (You may also look at
> >         # git log development/cmake/modules/FindCXX11Compiler.cmake
> > in lyx2.4 for changes prior to 2ec243d47)
> 
> 
> I either don't understand what I need to do or it does not help either. I
> put "--std=c++11" in there but it did not help, still the same error.

Alternatively you can try setting CMAKE_CXX_STANDARD directly.
Like in CMakeLists.txt:646
-if(NOT MSVC)
+if (MSVC)
+	set(CMAKE_CXX_STANDARD 11)
+else()

Since I cannot test for MSVC, it is untested.

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20240416/ba724ed8/attachment.asc>