Compiling With Qt5

[Kornel Benko]

Am Fri, 5 Apr 2024 17:23:57 -0400
schrieb Richard Kimberly Heck <rikiheck at gmail.com>:

> On 4/5/24 03:02, Kornel Benko wrote:
> > Am Thu, 4 Apr 2024 13:39:18 -0400
> > schrieb Richard Kimberly Heck <rikiheck at gmail.com>:
> >  
> >> On 4/3/24 06:34, Jean-Marc Lasgouttes wrote:  
> >>> Le 03/04/2024 à 12:27, Pavel Sanda a écrit :  
> >>>> On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote:  
> >>>>> Also, do we want Qt6 to be the default with 2.4.x? In master, that
> >>>>> might
> >>>>> make sense, but it seems odd to change that now.  
> >>>> I would not do that for 2.4 at this stage.  
> >>> I guess we could do that in a later 2.4 version, but this will need a
> >>> discussion.  
> >> I think it already is the default in the 2.4.x branch:
> >>
> >> ../lyx-2.4.x/build/ [2.4.x] > cmake ..
> >> CMake Deprecation Warning at CMakeLists.txt:7 (cmake_minimum_required):
> >>     Compatibility with CMake < 3.5 will be removed from a future version of
> >>     CMake.
> >>
> >>     Update the VERSION argument <min> value or use a ...<max> suffix to tell
> >>     CMake that the project does not need compatibility with older versions.
> >>
> >>
> >> -- TOP_SRC_DIR = /cvs/lyx/lyx-2.4.x  
> > We could use
> > 	# git cherry-pick 8d79860e
> > I omitted it in 2.4.x, because I did not want to mess ...  
> 
> Unless I'm misreading it, commit 993e784a6284a to 2.4.x makes Qt6 the 
> default (and that commit is also in 2.4.1-devel). When I run cmake on a 
> system with Qt6 installed, I get errors, since I don't have all the 
> devel files installed.
> 
> Riki
> 
> 

In this commit I only fixed the the wrong casing of "Qt6Core_Found" to "Qt6Core_FOUND".
So this code was there for a long time, but was not working.

The assumption is
	if there is devel package for qt6core, all other needed devel packages are
	also installed.

Committed at 7c8f3a5d on master. OK for 2.4.1 and/or 2.4.x?

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20240406/17adfcf9/attachment.asc>