ctest ca/Intro_docbook5 now failing

[Scott Kostyshak]

On Mon, Sep 25, 2023 at 12:57:40AM -0400, Scott Kostyshak wrote:
> On Mon, Sep 25, 2023 at 05:27:47AM +0200, Thibaut Cuvelier wrote:
> > On Mon, 18 Sept 2023 at 02:43, Thibaut Cuvelier <dourouc05 at gmail.com> wrote:
> > 
> > > On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak <skostysh at lyx.org> wrote:
> > >
> > >> On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote:
> > >> > Recently (I think due to the ca/Intro changes) the following test
> > >> started to fail:
> > >> >
> > >> >   export/doc/ca/Intro_docbook5
> > >> >
> > >> >  Thibaut, can you take a look? I'm guessing the recent changes to that
> > >> file just triggered a known issue with DocBook export. Can you confirm so
> > >> that we can invert that test?
> > >> >
> > >>
> > >> I just inverted it for now (at eb920502). Take a look whenever you have
> > >> time.
> > >>
> > >
> > > I had a look at that failure. It's a specific feature of that document,
> > > with an emphasis ending at the end of a footnote (with no character
> > > afterwards). Is this expected that someone can enter that? I would naïvely
> > > think that LyX would remove that formatting (just like you cannot have two
> > > spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the
> > > footnote, unlike DocBook.
> > >
> > > I have the idea for a fix; I'm waiting on your input on whether this is a
> > > DocBook bug or unexpected LyX behaviour.
> > >
> > 
> > I made up my mind and decided to replicate the same behaviour as LyXHTML
> > output: actually, there was some text, indicating a true bug in the
> > implementation. The attached patch fixes it locally, making it so that the
> > test can be uninverted. (As previously, I cannot push the commit onto the
> > Git repository.)
> 
> Thanks for working on it. I'll run the tests overnight with your patch applied.
> 
> Scott

Looks good! It's in at ff9dfa96.

Thanks,
Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230925/8f6a692d/attachment.asc>