[LyX/master] ctest: invert es/Intro_docbook5

Thibaut Cuvelier dourouc05 at gmail.com
Sun Oct 8 12:48:45 UTC 2023


Just a quick amendment to a previous patch (#1 in the series): there was a
quite big typo there... It should solve the largest issue with the newly
failing test, but not all. I'm having a look at this test to improve the
situation a bit more.

Thibaut Cuvelier


On Sun, 8 Oct 2023 at 04:23, Scott Kostyshak <skostysh at lyx.org> wrote:

> On Sun, Oct 08, 2023 at 01:55:23AM +0200, Thibaut Cuvelier wrote:
> > On Wed, 27 Sept 2023 at 19:46, Scott Kostyshak <skostysh at lyx.org> wrote:
> >
> > > On Wed, Sep 27, 2023 at 06:24:31PM +0200, Scott Kostyshak wrote:
> > > > commit bf241165dd9b30b26e45b5fcbab0e2bd0d143b4c
> > > > Author: Scott Kostyshak <skostysh at lyx.org>
> > > > Date:   Wed Sep 27 13:42:40 2023 -0400
> > > >
> > > >     ctest: invert es/Intro_docbook5
> > > >
> > > >     This fails after recent changes to the document.
> > > > ---
> > >
> > > Hi Thibaut,
> > >
> > > The es/Intro_docbook5 test is failing after changes to the document. I
> > > know some of these issues are very hard to add support for, so my plan
> > > is to just invert them when they happen and CC you so that you can
> > > decide whether it's worth spending time on or not.
> > >
> >
> > I'm attaching a patch that fixes the output from InsetInfo to match the
> > LaTeX output. This patch might be slightly controversial, since LyX 2.4
> is
> > nearing the release; I made sure to touch the DocBook parts of the code
> > only to lower the risk of breakage.
>
> > Also, I'm adding two much smaller patches: one that improves code
> > readability, one that fixes a bug about formatting and change tracking.
>
> Seems fine to me. Riki, is it OK with you if I commit Thibaut's patches to
> master?
>
> > I have manually checked that doc/es/Intro generates valid DocBook 5
> (i.e. I
> > believe the test could be uninverted). Let me know if you find more
> issues!
> >
> > Could someone please check this in the Git repository? Thanks!
>
> The following test now fails:
>
>
> export/examples/Language_Support/Mixing_Japanese_with_other_Languages_%28with_CJKutf8%29_docbook5
>
> Scott
> --
> lyx-devel mailing list
> lyx-devel at lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/c6229f5a/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-DocBook-fix-formatting-of-TODOs.patch
Type: application/octet-stream
Size: 2192 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/c6229f5a/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DocBook-add-support-for-InsetInfo.patch
Type: application/octet-stream
Size: 27577 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/c6229f5a/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-DocBook-fix-closing-formatting-after-deleted-text.patch
Type: application/octet-stream
Size: 5471 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/c6229f5a/attachment-0005.obj>


More information about the lyx-devel mailing list