[LyX/master] ctest: invert es/Intro_docbook5

[Thibaut Cuvelier]

On Wed, 27 Sept 2023 at 19:46, Scott Kostyshak <skostysh at lyx.org> wrote:

> On Wed, Sep 27, 2023 at 06:24:31PM +0200, Scott Kostyshak wrote:
> > commit bf241165dd9b30b26e45b5fcbab0e2bd0d143b4c
> > Author: Scott Kostyshak <skostysh at lyx.org>
> > Date:   Wed Sep 27 13:42:40 2023 -0400
> >
> >     ctest: invert es/Intro_docbook5
> >
> >     This fails after recent changes to the document.
> > ---
>
> Hi Thibaut,
>
> The es/Intro_docbook5 test is failing after changes to the document. I
> know some of these issues are very hard to add support for, so my plan
> is to just invert them when they happen and CC you so that you can
> decide whether it's worth spending time on or not.
>

I'm attaching a patch that fixes the output from InsetInfo to match the
LaTeX output. This patch might be slightly controversial, since LyX 2.4 is
nearing the release; I made sure to touch the DocBook parts of the code
only to lower the risk of breakage.

Also, I'm adding two much smaller patches: one that improves code
readability, one that fixes a bug about formatting and change tracking.

I have manually checked that doc/es/Intro generates valid DocBook 5 (i.e. I
believe the test could be uninverted). Let me know if you find more issues!

Could someone please check this in the Git repository? Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/6f45abcc/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DocBook-add-support-for-InsetInfo.patch
Type: application/x-patch
Size: 27578 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/6f45abcc/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-DocBook-fix-formatting-of-TODOs.patch
Type: application/x-patch
Size: 2192 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/6f45abcc/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-DocBook-fix-closing-formatting-after-deleted-text.patch
Type: application/x-patch
Size: 5471 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20231008/6f45abcc/attachment-0005.bin>