Deprecated functions with lyx-2.3.7dev

[Jean-Marc Lasgouttes]

Le 10/11/2023 à 03:38, Richard Kimberly Heck a écrit :
>> The solution can be divided in two parts :
>>
>> 1/ decide that we do not care about obsolete methods or compatibility 
>> problems with recent C++ versions. The idea is that 2.3 is stuck with 
>> C++11/14 and that what heppens with other versions is none of our 
>> business.
>>
>> 2/ find a correct implementation. I used the macro that we already 
>> used to add -Wno-c++20-compat with versions of gcc that support it. 
>> For the other one (-Wno-deprecated-declarations), I checked that it 
>> was already present in gcc 4.9.
>>
>> I can try to test with various clang versions too.
> 
> Your call.

I do not know anymore :)

The good thing is that removing these patches allowed me to uncover two 
smaller-scoped warnings that had not been backported (one was a real 
issue). But, well, this is done now, so the gain is not for the future.

Release of 2.3.8 will be compiled without warnings enabled (at least on 
autotools), so we may say that we do not care about removing warnings. 
So in some sense muting those warning is a (very) potential risk with a 
smallish benefit.

Pavel, José, what are your thought on this?

JMarc