[LyX/master] Do not return copies of string members

[Jean-Marc Lasgouttes]

Le 09/05/2023 à 22:08, Enrico Forestieri a écrit :
> On Fri, May 05, 2023 at 07:28:59PM +0200, Jean-Marc Lasgouttes wrote:
>>
>> commit 3ae5d6bdec1df23cc0d848b2d8bf6b0932eeee3b
>> Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
>> Date:   Fri May 5 20:35:23 2023 +0200
>>
>>    Do not return copies of string members
>>
>>    This fixes the g++ 12 warnings below.
> 
> After this commit my cygwin build crashes badly at startup. I can't even 
> get a backtrace. What is strange is that a native Windows build works 
> fine, instead. Both builds use the same version of gcc:

Strange... Did you try to run it under valgrind or something similar?

I do not see that. Valgrind output horrors (more on that later), but not 
related to this. Did you check whether a full rebuild helps?

JMarc
>