Using lyxhtml_validity.py

Thibaut Cuvelier dourouc05 at gmail.com
Mon Jan 9 03:20:48 UTC 2023


On Sun, 8 Jan 2023 at 17:11, Kornel Benko <kornel at lyx.org> wrote:

> Am Sun, 8 Jan 2023 10:57:40 -0500
> schrieb Scott Kostyshak <skostysh at lyx.org>:
>
> > > Same here. To disable the validity-check simply comment the line
> > >     development/autotests/export.cmake:335
> > > -->         #check_xhtml_validate(${result_file_name})
> >
> > Would it be reasonable to commit everything, but keep the validity-check
> > commented out? That way it would at least be a bit easier for Thibaut to
> > just uncomment the extra check when they want to run it?
> >
> > I still prefer for it to be commented out by default, until the tests
> > pass for us.
> >
> > Scott
>
> Yes, that was also one reason to refactor export.cmake.
>
> I will commit.
>

Sorry for the series of emails, I didn't see the latest developments when I
started replying...

Regarding simplehtml_validity.py, I think you went a bit fast when
simplifying my code, with many parts now useless. I suggest the attached
patch.

I'm currently running the new test suite (with the check_xhtml_validate(${
result_file_name}) line uncommented).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230109/7a3f2b54/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simplify-simplehtml_validity.py.patch
Type: application/octet-stream
Size: 1688 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230109/7a3f2b54/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Export-tests-use-a-better-function-name.patch
Type: application/octet-stream
Size: 1363 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230109/7a3f2b54/attachment-0001.obj>


More information about the lyx-devel mailing list