Using lyxhtml_validity.py

[Scott Kostyshak]

On Sun, Jan 08, 2023 at 04:48:31PM +0100, Kornel Benko wrote:
> Am Sun, 8 Jan 2023 10:32:25 -0500
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> > On Sun, Jan 08, 2023 at 04:22:09PM +0100, Kornel Benko wrote:
> > > Am Sun, 8 Jan 2023 10:11:37 -0500
> > > schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> [skip]
> 
> > > > -- Msg Summary: -- 	OK: Exporting
> > > > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_UxUzu8/doc/Intro.lyx"
> > > > to format xhtml -- 	Error: 1 validating  
> > > 
> > > This is suspicious. I get here
> > > 	Error: 254 validating
> > > Maybe you forgot to install html5validator?
> > > 	$ pip3 install html5validator>=0.4.2
> > >   
> > > > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_UxUzu8/doc/Intro.xhtml.validate_out"
> > > > -- 	OK: Checking
> > > > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_UxUzu8/doc/Intro.xhtml"
> > > > with /usr/bin/xmllint -- 	OK: Parse messages of /usr/bin/xmllint for errors
> > > > -- Exporting doc/Intro.lyx to xhtml CMake Error at
> > > > /home/scott/lyxbuilds/master-master/repo/development/autotests/export.cmake:369
> > > > (message): Export failed  
> > 
> > Ah yes you are right. Now I get:
> > 
> > 
> > -- Expected result file
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml"
> > exists -- Calling /usr/bin/python3.10
> > "/home/scott/lyxbuilds/master-master/repo/development/autotests/simplehtml_validity.py"
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml"
> > -- Error: Bad value "content-type" for attribute "http-equiv" on element "meta". From
> > line 5, column 1; to line 5, column 69 in resource
> > file:/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml
> > Error: The "align" attribute on the "td" element is obsolete. Use CSS instead. From
> > line 316, column 1; to line 316, column 103 in resource
> > file:/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml
> > Error: The "valign" attribute on the "td" element is obsolete. Use CSS instead. ...
> > [cut many messages] Error: The "valign" attribute on the "td" element is obsolete. Use
> > CSS instead. From line 434, column 1; to line 434, column 102 in resource
> > file:/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml
> > Document checking completed.
> > > Found 163 validation errors!  
> > 
> > -- Calling: /usr/bin/xmllint --loaddtd --noout
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml"
> > -- Check the output: /usr/bin/perl
> > /home/scott/lyxbuilds/master-master/repo/development/autotests/examineXmllintOutput.pl
> > -- Msg Summary: -- 	OK: Exporting
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.lyx"
> > to format xhtml -- 	Error: 254 validating
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml.validate_out"
> > -- 	Error: Non empty output
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml.validate_out"
> > with "symplehtml_validity.py" -- 	OK: Checking
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_GWnnqL/doc/Intro.xhtml"
> > with /usr/bin/xmllint -- 	OK: Parse messages of /usr/bin/xmllint for errors --
> > Exporting doc/Intro.lyx to xhtml CMake Error at
> > /home/scott/lyxbuilds/master-master/repo/development/autotests/export.cmake:369
> > (message): Export failed
> > 
> > Scott
> 
> Same here. To disable the validity-check simply comment the line
> 	development/autotests/export.cmake:335
> -->		#check_xhtml_validate(${result_file_name})

Would it be reasonable to commit everything, but keep the validity-check
commented out? That way it would at least be a bit easier for Thibaut to
just uncomment the extra check when they want to run it?

I still prefer for it to be commented out by default, until the tests
pass for us.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230108/6f836789/attachment.asc>