Bug: counter of recent documents in Preferences dialog

[Dan]

>> The problem
>> --------------------
>> Follow through
>>  1. Run Lyx (version, build and OS info in the text attatchment).
>>  2. Open the Preferences dialog (Tools > Preferences). 3. In the Look and Feel section, choose User Interface.
>>  4. Set the number of recent documents to more than 9.
>>  5. The last digit of the two-digit number is barely visible (see attatched image).
>>
>
> Should be fixed by 06198fbe1854.
>

Could you actually reproduce the problem? I ask because I get the same problem after your patch.

Honestly, I am confused right now
 1. I tried both versions (prior to and after your patch) in Debian 12.1 with MATE 1.26, and the problem did not appear.
 2. Although your patch (https://www.lyx.org/trac/changeset?old_path=%2Flyxgit&old=06198fbe1854c64cd62acdbd8bcaafdb2a3b3b9e&new_path=%2Flyxgit&new=06198fbe1854c64cd62acdbd8bcaafdb2a3b3b9e) does not fix the problem (in my Linuxmint 21.2  with Cinnamon at least), it really SHOULD: actually just setting the maximum property to 10 should suffice.
 3. The maximum limit set in the QT ui file is ignored: actual maximum is always 50 (you can check by running the program and incrementing one by one). Therefore, this problem should not appear to begin with...

For contrast see Tools > Preferences > Look & Feel > Document Handling.
The spin box for the number of minutes (https://www.lyx.org/trac/browser/lyxgit/src/frontends/qt/ui/PrefDocHandlingUi.ui#L111): if you change the maximum from 300 to 100 or 9 and compile, the spinbox shrinks! So it seems spinboxes adjust their size to be able to accomodate their range limits, which actually makes sense, since it won't let you get past those limits.
The structure of this UI element (container layout) is the very same as the recent documents spinbox, so I guess something is done in code to this particular preference to override the maximum limit given in the QT ui file.

At this point I suggest reverting the change you made, unless someone else claims to have reproduced the bug. But it is just a suggestion.


Sorry for the headache :(.


Daniel.
--
Enviat amb Tutanota.