Remove Qt < 5.2 conditionals and special code

[Scott Kostyshak]

On Thu, Aug 17, 2023 at 10:18:13AM +0200, Jürgen Spitzmüller wrote:
> Am Donnerstag, dem 17.08.2023 um 10:01 +0200 schrieb Jürgen
> Spitzmüller:
> > According to the README, we require Qt 5.2 or higher for 2.4.
> > 
> > There is still some code for Qt < 5.2 in the source. Particularly a
> > self-baked "Don't ask me again" warning dialog.
> > 
> > OK to remove that (see patch)?
> 
> I also found some Qt 5.1 checks, see updated patch.

I'm not necessarily against it, but the argument for keeping that code is that it might be helpful to do a bisect of Qt to figure out a Qt bug. The reason we require a higher Qt 5.x is that *some* things don't work well, but if I recall correctly most things do, so it is possible to compile and test.

This was the cost/benefit of removing Qt 4.x, and removing Qt 4.x support cleaned up the code a lot. So it comes down to whether the benefit of cleaning up outweighs the cost of not being able to narrow in on what might be a Qt bug.

On the other hand, If I want to bisect Qt to look for a Qt bug (which I really don't want to do!), I could check out an earlier commit, before you removed the code (if this patch is committed) and proceed. So I guess the only issue is if there's a bug that shows up only on future master, that cannot be reproduced on current master, that I would not be able to check.

I'm really fine with the patch since I agree there's a value in cleaning up, but I just wanted to mention the cost of removing the code since you didn't mention it.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230817/2d49731f/attachment.asc>