Cursor in front of image half invisible

Pavel Sanda sanda at lyx.org
Thu Apr 27 15:54:35 UTC 2023


On Fri, Apr 14, 2023 at 10:43:31PM +0200, Pavel Sanda wrote:
> > Is your proposal to have at least leftOffset == rightOffset == 2 ?
> 
> I am proposing to have at least 2 pixels ahead of the graphics inset,
> not sure what that means in InsetGraphics.h language...

On my screen leftOffset = 3 & rightOffset = 2 looks best.

But on different screens might feel different. 
Anyway at least 2 pixels on each side seem neccessary.

Attached is proposed change. Opinion?
Pavel
-------------- next part --------------
diff --git a/src/insets/InsetGraphics.h b/src/insets/InsetGraphics.h
index 2f0156dfc9..ff450d1b9a 100644
--- a/src/insets/InsetGraphics.h
+++ b/src/insets/InsetGraphics.h
@@ -97,9 +97,9 @@ public:
 	///
 	int bottomOffset(BufferView const *) const override { return 0; }
 	///
-	int leftOffset(BufferView const *) const override { return 0; }
+	int leftOffset(BufferView const *) const override { return 3; }
 	///
-	int rightOffset(BufferView const *) const override { return 0; }
+	int rightOffset(BufferView const *) const override { return 2; }
 
 	///
 	void metrics(MetricsInfo &, Dimension &) const override;


More information about the lyx-devel mailing list