Cursor in front of image half invisible

[Pavel Sanda]

On Fri, Apr 14, 2023 at 12:21:30PM +0200, Jean-Marc Lasgouttes wrote:
> Le 14/04/2023 ?? 10:21, Pavel Sanda a écrit :
> >It is better in the sense that it does not look outright buggy, but it still looks
> >weird. When I added another +1 pixel is looks tight but OK-ish, +2 even better IMHO.
> 
> Where do you add pixels? In left/right offset?

I just took your script and put the same X pixels into:
int leftOffset(BufferView const *) const override { return X; }
...
pi.pain.rectangle(x1, y1, w - X, h, c);

It looks reasonable in that one particular case with cursor ahead of image
but I really do not know what I am doing or what else I am breaking :)

> One reason I had for making this tight was that it looks IMO awful with
> InsetInfo's icons.

The change for X=2 seems to looks fine with one inset info example I just tried.

> Would it help to have the cursor at least as tall as the preceding inset
> (LibreOffice does that)?

You mean the size of following (not preceding) image? That would look IMHO horrible.

> Is your proposal to have at least leftOffset == rightOffset == 2 ?

I am proposing to have at least 2 pixels ahead of the graphics inset,
not sure what that means in InsetGraphics.h language...

Pavel