[LyX/master] Fixes to heb-article, by Udi Fogiel (#12735)

[Udicoudco]

On Mon, Apr 10, 2023 at 8:22 PM Udicoudco <udifoglle at gmail.com> wrote:
>
> On Mon, Apr 10, 2023 at 7:34 PM Scott Kostyshak <skostysh at lyx.org> wrote:
> >
> > On Mon, Apr 10, 2023 at 05:19:51PM +0200, Juergen Spitzmueller wrote:
> > > commit d0a83d33fcc0db64bd2b8bc79671c4427ddc18e6
> > > Author: Juergen Spitzmueller <spitz at lyx.org>
> > > Date:   Mon Apr 10 18:24:04 2023 +0200
> > >
> > >     Fixes to heb-article, by Udi Fogiel (#12735)
> > >
> > >     For some reason theorems titles has \beginR without a \endR, and since
> > >     this is basically inside restricted horizontal mode, TeX complains about
> > >     a missing \endR.
> > >
> > >     I could not figure out why were they there in the first place so I
> > >     removed them and the output did not change, and the warnings are gone.
> > >
> > >     Beside that the numbering of the theorems is wrong (e.g. 1.0 instead of
> > >     0.1), the \@makelr thing should happen after babel is loaded.
> > >
> > >     The theorems layouts did not have a counter (in LyX) so I added one.
> > > ---
> >
> > >  Style Remarks
> > >       CopyStyle             Theorem
> > >       LatexName             remark
> > > -     LabelString           "Remarks #."
> > > +     LabelString           "הערות \thetheorem."
> >
> > Should the LabelString be untranslated, like: "Remarks \thetheorem." ?
>
> Note that LyX  does not translate Remarks, and הערות is hardcoded in
> the latex definition,
> isn't it preferable that LyX will display הערות in this case?

Should I add Remarks to layouttranslation for hebrew?

> > --
> > lyx-devel mailing list
> > lyx-devel at lists.lyx.org
> > http://lists.lyx.org/mailman/listinfo/lyx-devel