[LyX/master] Amend 1dc66608
Scott Kostyshak
skostysh at lyx.org
Mon Apr 10 17:16:09 UTC 2023
On Mon, Apr 10, 2023 at 06:08:58PM +0200, Scott Kostyshak wrote:
> commit 7368e5be2be2c24f5cb363443d86c72973bd2719
> Author: Scott Kostyshak <skostysh at lyx.org>
> Date: Mon Apr 10 13:10:11 2023 -0400
>
> Amend 1dc66608
>
> Declare override, otherwise we get the following warning:
>
> src/insets/InsetListings.h:42:7: error: 'isEnvironment' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
> bool isEnvironment() const { return !params().isInline(); }
> ^
> src/insets/Inset.h:606:15: note: overridden virtual function is here
> virtual bool isEnvironment() const { return getLayout().latextype() == InsetLaTeXType::ENVIRONMENT; }
> ^
> 1 error generated.
> ---
> src/insets/InsetListings.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/insets/InsetListings.h b/src/insets/InsetListings.h
> index 080b7b7..d75f968 100644
> --- a/src/insets/InsetListings.h
> +++ b/src/insets/InsetListings.h
> @@ -39,7 +39,7 @@ public:
> ///
> static std::string params2string(InsetListingsParams const &);
> ///
> - bool isEnvironment() const { return !params().isInline(); }
> + bool isEnvironment() const override { return !params().isInline(); }
> private:
> ///
> bool isLabeled() const override { return true; }
Jürgen can you check this change is OK?
Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230410/b8b4e95e/attachment.asc>
More information about the lyx-devel
mailing list