[LyX/master] Fixes to heb-article, by Udi Fogiel (#12735)

[Scott Kostyshak]

On Mon, Apr 10, 2023 at 06:51:16PM +0200, Kornel Benko wrote:
> Am Mon, 10 Apr 2023 12:33:36 -0400
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> > On Mon, Apr 10, 2023 at 05:19:51PM +0200, Juergen Spitzmueller wrote:
> > > commit d0a83d33fcc0db64bd2b8bc79671c4427ddc18e6
> > > Author: Juergen Spitzmueller <spitz at lyx.org>
> > > Date:   Mon Apr 10 18:24:04 2023 +0200
> > > 
> > >     Fixes to heb-article, by Udi Fogiel (#12735)
> > >     
> > >     For some reason theorems titles has \beginR without a \endR, and since
> > >     this is basically inside restricted horizontal mode, TeX complains about
> > >     a missing \endR.
> > >     
> > >     I could not figure out why were they there in the first place so I
> > >     removed them and the output did not change, and the warnings are gone.
> > >     
> > >     Beside that the numbering of the theorems is wrong (e.g. 1.0 instead of
> > >     0.1), the \@makelr thing should happen after babel is loaded.
> > >     
> > >     The theorems layouts did not have a counter (in LyX) so I added one.
> > > ---  
> > 
> > >  Style Remarks
> > >  	CopyStyle             Theorem
> > >  	LatexName             remark
> > > -	LabelString           "Remarks #."
> > > +	LabelString           "הערות \thetheorem."  
> > 
> > Should the LabelString be untranslated, like: "Remarks \thetheorem." ?
> > 
> > Scott
> 
> This "הערות" also breaks the compilation with msguniq

Same here. I amended the commit at e3288b4b. Jürgen is that change OK?

It would be nice to improve the msguniq error message, or provide our own check earlier and give a more helpful message. The message I had was not very helpful:

/usr/bin/msguniq: input file '/home/scott/lyxbuilds/master-master/CMakeBuild/po/lyx2.4.cat.pot' doesn't contain a header entry with a charset specification

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20230410/d458689c/attachment.asc>