[PATCH] Show branches from master document in branch inset dialog

[Jürgen Spitzmüller]

Am Donnerstag, dem 06.10.2022 um 20:39 +0300 schrieb Yuriy Skalko:
> Hello all,
> 
> Currently in LyX you can insert into child documents the insets for 
> branches defined in master document only. But it is impossible to
> change 
> the branch afterwards for such inset because master branches are not 
> shown in the "Branch Settings" dialog.
> 
> The attached patch fixes this.

Looks good. One nitpick:

+			if (!branchlist.find(branch)) {
+				branchCO->addItem(toqstr(branch + _("
(master)")), toqstr(branch));

I'd use boost format for this:

branchCO->addItem(
	toqstr(bformat(	_("%1$s[[branch]] (%2$s)[[master]]"),
	       toqstr(branch), qt_("master"))));

since with RTL scripts your precomposed string will be wrong I think.

> 
> Yuriy
> 

-- 
Jürgen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221007/0b09aa16/attachment.asc>