[LyX/master] Merge branch 'features/indexmacros'

[Scott Kostyshak]

On Thu, Nov 03, 2022 at 08:59:27PM -0400, Scott Kostyshak wrote:
> On Thu, Nov 03, 2022 at 10:04:31PM +0100, Thibaut Cuvelier wrote:
> > On Thu, 3 Nov 2022 at 21:27, Scott Kostyshak <skostysh at lyx.org> wrote:
> > 
> > > On Mon, Oct 31, 2022 at 11:38:46PM -0400, Scott Kostyshak wrote:
> > > > On Tue, Nov 01, 2022 at 12:01:47AM +0100, Thibaut Cuvelier wrote:
> > > > > On Mon, 31 Oct 2022 at 21:12, Jürgen Spitzmüller <jspitzm at gmail.com>
> > > wrote:
> > > > >
> > > > > > Am Montag, dem 31.10.2022 um 14:58 -0400 schrieb Scott Kostyshak:
> > > > > > > I get the following warning:
> > > > > > >
> > > > > > > /home/scott/lyxbuilds/master-
> > > > > > > master/repo/src/insets/InsetIndex.cpp:1691:6: error: function
> > > > > > > 'printTree' is not needed and will not be emitted [-Werror,-
> > > > > > > Wunneeded-internal-declaration]
> > > > > > > void printTree(const IndexNode* root_node, unsigned depth = 0)
> > > > > > >      ^
> > > > > > > 1 error generated.
> > > > > >
> > > > > > I can have a look, but I think this is a method added by Thibaut.
> > > > >
> > > > >
> > > > > I've pushed 3bf1b97ae547aea5d0243e41b2d8af463a6e40c5 to master; it
> > > should
> > > > > solve the issue. Scott, let me know if it works for you.
> > > >
> > > > Thanks! I see the following failures:
> > > >
> > > >   export/doc/Math_xhtml (Failed)
> > > >   export/doc/de/Additional_xhtml (Failed)
> > > >   export/doc/de/Math_xhtml (Failed)
> > > >   export/doc/de/UserGuide_xhtml (Failed)
> > > >   export/doc/es/Math_xhtml (Failed)
> > > >   export/doc/fr/Math_xhtml (Failed)
> > > >   export/doc/ja/Math_xhtml (Failed)
> > > >   export/doc/ru/Math_xhtml (Failed)
> > > >
> > > > Thibaut, can you look at those?
> > >
> > > Thibaut, can you take a look? From what I understand, these were passing
> > > before the merge. The doc/Math_xhtml one seems to have been fixed
> > > recently somehow, but the other ones still fail:
> > >
> > >   export/doc/de/Additional_xhtml (Failed)
> > >   export/doc/de/Math_xhtml (Failed)
> > >   export/doc/de/UserGuide_xhtml (Failed)
> > >   export/doc/es/Math_xhtml (Failed)
> > >   export/doc/fr/Math_xhtml (Failed)
> > >   export/doc/ja/Math_xhtml (Failed)
> > >   export/doc/ru/Math_xhtml (Failed)
> > >
> > > For example, for the de Additional_xhtml, I see in the log:
> > >
> > > -- Errors from xmllint: doc/de/Additional.xhtml:4451: parser error :
> > > EntityRef: expecting ';'
> > > A&A Paper — <a href='#magicparlabel-1252'>1</a></li>
> > >
> > > Is it because '&' needs to be escaped?
> > >
> > 
> > In this example, the & in A&A should be escaped (& or  &). If you
> > can fix that quickly, that'd be nice, otherwise, I'll have a look,
> > tentatively this week-end.
> 
> Thanks for the quick reply, Thibaut. I would prefer if you took care of
> it since you are more familiar with this code.

Hi Thibaut,

Just a reminder to take a look at these failing tests.

Thanks,
Scott